[BoundsSafety][LLDB] Try to Fix bounds_safety_soft_trap*_missing_reason tests on Linux
#11883
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son` tests on Linux
The tests were failing with:
```
/home/build-user/llvm-project/lldb/test/Shell/BoundsSafety/Inputs/boundsSafetySoftTrapsMissingReason.c:5:32: error: a parameter list without types is only allowed in a function definition
5 | int bad_call(int *__counted_by(count) ptr, int count) {}
| ^
/home/build-user/llvm-project/lldb/test/Shell/BoundsSafety/Inputs/boundsSafetySoftTrapsMissingReason.c:5:39: error: expected ')'
5 | int bad_call(int *__counted_by(count) ptr, int count) {}
| ^
/home/build-user/llvm-project/lldb/test/Shell/BoundsSafety/Inputs/boundsSafetySoftTrapsMissingReason.c:5:13: note: to match this '('
5 | int bad_call(int *__counted_by(count) ptr, int count) {}
| ^
2 errors generated.
```
This is happening because `__counted_by` is a macro but the `ptrcheck.h`
header that defines it is not included. This wasn't caught on macOS
because the Libc headers on that platform automatically include that
header.
I don't have a Linux VM to hand so this is a speculative fix that should
fix the include issue.
rdar://165202129
delcypher
added
the
clang:bounds-safety
Author
|
@swift-ci test |
JDevlieghere
approved these changes
Nov 21, 2025
Author
|
macOS test failures: |
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing with:
This is happening because
__counted_byis a macro but theptrcheck.hheader that defines it is not included. This wasn't caught on macOS
because the Libc headers on that platform automatically include that
header.
I don't have a Linux VM to hand so this is a speculative fix that should
fix the include issue.
rdar://165202129